Convenient preconditions specific for Crashlytics concurrency #6125

mrober · 2024-07-25T19:21:32Z

No description provided.

github-actions · 2024-07-25T19:21:45Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/CrashlyticsPreconditions.kt

google-oss-bot · 2024-07-25T19:25:51Z

Coverage Report ¹

Affected Products

firebase-crashlytics
Overall coverage changed from 11.32% (856457a) to 11.27% (3019e82) by -0.05%.
Filename Base (856457a) Merge (3019e82) Diff
CrashlyticsPreconditions.kt ? 0.00% ?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/kYmmF0jzIZ.html

github-actions · 2024-07-25T19:30:14Z

Unit Test Results

  8 files -     948   8 suites - 948 23s ⏱️ - 34m 22s
22 tests -   5 242 22 ✔️ -   5 211 0 💤 - 21 0 ❌ - 10
44 runs - 10 569 44 ✔️ - 10 517 0 💤 - 42 0 ❌ - 10

Results for commit d317159. ± Comparison against base commit 856457a.

google-oss-bot · 2024-07-25T19:30:55Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (856457a) Merge (3019e82) Diff
aar 408 kB 417 kB +8.75 kB (+2.1%)
apk (aggressive) 695 kB 695 kB +196 B (+0.0%)
apk (release) 5.84 MB 5.84 MB +6.16 kB (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/KSwUR8d4Tl.html

google-oss-bot · 2024-07-25T19:55:02Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (856457a) and the CI merge commit (3019e82)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 856457a: https://storage.googleapis.com/firebase-sdk-metric-reports/QeKeqwvPSe/index.html
- 3019e82: https://storage.googleapis.com/firebase-sdk-metric-reports/Q0KmAjHHjE/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	10.8 ±2 ms	10.3 ±2 ms	-587 μs (-5.4%)	NO
p25	11.5 ±3 ms	10.9 ±3 ms	-574 μs (-5.0%)	NO
p50	12.3 ±3 ms	11.9 ±3 ms	-429 μs (-3.5%)	NO
p75	13.6 ±3 ms	13.0 ±3 ms	-543 μs (-4.0%)	NO
p90	15.1 ±3 ms	14.6 ±3 ms	-480 μs (-3.2%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

redfin-30

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	14.3 ±4 ms	15.7 ±5 ms	+1.41 ms (+9.8%)	NO
p25	15.0 ±5 ms	16.6 ±6 ms	+1.54 ms (+10.2%)	NO
p50	16.1 ±6 ms	17.8 ±7 ms	+1.77 ms (+11.0%)	NO
p75	17.4 ±7 ms	20.0 ±9 ms	+2.58 ms (+14.8%)	NO
p90	19.1 ±7 ms	22.8 ±9 ms	+3.65 ms (+19.1%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	133 ±121 μs	222 ±373 μs	+89.6 μs (+67.6%)	NO
p25	139 ±124 μs	234 ±389 μs	+94.9 μs (+68.2%)	NO
p50	151 ±133 μs	258 ±408 μs	+107 μs (+70.6%)	NO
p75	196 ±180 μs	297 ±456 μs	+101 μs (+51.6%)	NO
p90	238 ±194 μs	364 ±508 μs	+127 μs (+53.3%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

redfin-30

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	412 ±462 μs	388 ±502 μs	-24.3 μs (-5.9%)	NO
p25	468 ±548 μs	446 ±576 μs	-21.7 μs (-4.6%)	NO
p50	568 ±651 μs	545 ±694 μs	-22.7 μs (-4.0%)	NO
p75	700 ±814 μs	663 ±831 μs	-37.9 μs (-5.4%)	NO
p90	886 ±1018 μs	913 ±1126 μs	+26.3 μs (+3.0%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	2.95 ±0.7 ms	2.52 ±0.3 ms	-430 μs (-14.6%)	NO
p25	3.16 ±0.7 ms	2.67 ±0.3 ms	-495 μs (-15.7%)	NO
p50	3.50 ±0.7 ms	3.00 ±0.4 ms	-502 μs (-14.4%)	NO
p75	4.07 ±0.8 ms	3.51 ±0.5 ms	-563 μs (-13.8%)	NO
p90	4.83 ±1 ms	4.28 ±0.8 ms	-551 μs (-11.4%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

redfin-30

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	6.06 ±1 ms	5.95 ±1 ms	-112 μs (-1.9%)	NO
p25	6.51 ±2 ms	6.36 ±2 ms	-151 μs (-2.3%)	NO
p50	7.03 ±2 ms	7.02 ±2 ms	-14.5 μs (-0.2%)	NO
p75	7.91 ±3 ms	8.06 ±4 ms	+155 μs (+2.0%)	NO
p90	9.02 ±4 ms	9.15 ±4 ms	+128 μs (+1.4%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	201 ±4 ms	207 ±4 ms	+6.44 ms (+3.2%)	NO
p25	206 ±4 ms	213 ±3 ms	+6.39 ms (+3.1%)	NO
p50	213 ±4 ms	220 ±2 ms	+6.59 ms (+3.1%)	NO
p75	221 ±4 ms	228 ±3 ms	+6.92 ms (+3.1%)	NO
p90	231 ±5 ms	239 ±4 ms	+8.46 ms (+3.7%)	NO

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

redfin-30

Percentile	`856457a`	`3019e82`	Diff	Significant (?)
p10	241 ±5 ms	264 ±4 ms	+22.8 ms (+9.4%)	YES
p25	247 ±4 ms	269 ±4 ms	+22.8 ms (+9.2%)	YES
p50	254 ±3 ms	276 ±4 ms	+22.8 ms (+9.0%)	YES
p75	261 ±3 ms	284 ±5 ms	+23.5 ms (+9.0%)	YES
p90	269 ±6 ms	297 ±5 ms	+28.7 ms (+10.7%)	YES

20 test runs in comparison

Commit	Test Runs
`856457a`	2024-07-24_21:20:50.876854_QhMu 2024-07-24_21:20:50.876897_CJlf 2024-07-24_21:20:50.876909_Jzxk 2024-07-24_21:20:50.876917_TJSl 2024-07-24_21:20:50.876924_GreK 2024-07-24_21:20:50.876932_TCzz 2024-07-24_21:20:50.876939_KzTQ 2024-07-24_21:20:50.876946_lImN 2024-07-24_21:20:50.876953_TbdM 2024-07-24_21:20:50.876960_yDCB
`3019e82`	2024-07-25_19:33:26.534213_fZyf 2024-07-25_19:33:26.534260_OLET 2024-07-25_19:33:26.534271_zcDm 2024-07-25_19:33:26.534279_TPSC 2024-07-25_19:33:26.534296_VIUr 2024-07-25_19:33:26.534304_XHvb 2024-07-25_19:33:26.534311_DAEv 2024-07-25_19:33:26.534318_UICN 2024-07-25_19:33:26.534325_AQQT 2024-07-25_19:33:26.534331_jfeK

https://storage.googleapis.com/firebase-sdk-metric-reports/htQdNedpEB/index.html

mrober · 2024-07-26T12:27:25Z

#4345

Convenient preconditions specific for Crashlytics concurrency

d317159

mrober added no-changelog main-merge-ack labels Jul 25, 2024

mrober requested a review from themiswang July 25, 2024 19:21

google-oss-bot added the size/L label Jul 25, 2024

themiswang approved these changes Jul 25, 2024

View reviewed changes

themiswang reviewed Jul 25, 2024

View reviewed changes

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/CrashlyticsPreconditions.kt Show resolved Hide resolved

mrober merged commit 1b49171 into main Jul 26, 2024
46 checks passed

mrober deleted the crashlytics-preconditions branch July 26, 2024 12:27

firebase locked and limited conversation to collaborators Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convenient preconditions specific for Crashlytics concurrency #6125

Convenient preconditions specific for Crashlytics concurrency #6125

Uh oh!

mrober commented Jul 25, 2024

Uh oh!

github-actions bot commented Jul 25, 2024 •

edited

Loading

Uh oh!

Uh oh!

google-oss-bot commented Jul 25, 2024

`firebase-crashlytics`

Uh oh!

github-actions bot commented Jul 25, 2024

Uh oh!

google-oss-bot commented Jul 25, 2024

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Jul 25, 2024

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

mrober commented Jul 26, 2024

Uh oh!

Uh oh!

Uh oh!

Convenient preconditions specific for Crashlytics concurrency #6125

Convenient preconditions specific for Crashlytics concurrency #6125

Uh oh!

Conversation

mrober commented Jul 25, 2024

Uh oh!

github-actions bot commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

Uh oh!

google-oss-bot commented Jul 25, 2024

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

github-actions bot commented Jul 25, 2024

Unit Test Results

Uh oh!

google-oss-bot commented Jul 25, 2024

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

google-oss-bot commented Jul 25, 2024

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

Uh oh!

mrober commented Jul 26, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 25, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

Size Report ¹

`firebase-crashlytics`

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`